Avoid a possible recursive copy when destination (build_dir) is underneath source directory #1026
+17
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any feedback on this PR? |
|
I'm having trouble figuring out the configuration where this is a problem. If I set |
|
When you have the book.toml file in the root of your project. in book.toml you have and the build dir is also under the root somewhere, something like So, during the build all the contents of "src" (so all files - except filtered .md files) are copied into "target", including "target" itself - recursing. in short: when "build-dir" is a subdir of "src". |
ehuss
reviewed
Oct 7, 2019
|
OK, I hope that addresses the two comments on texts in the PR. |
…neath source directory. Update docs to match.
|
Thanks. I'll switch to release v0.3.7 now! |
Ruin0x11
pushed a commit
to Ruin0x11/mdBook
that referenced
this pull request
Aug 30, 2020
Avoid a possible recursive copy when destination (build_dir) is underneath source directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user makes a mistake in config
mdbookcould have started a never-ending copy that only ends when your disk is full. This change avoids that.It also makes it possible to create a valid (if not recommended) configuration where your
build-diris underneath thesrcdirectory. One reason for possibly wishing to do that is when you desiresrcto be the root directory of a project.Relates to #1024